Nested Sets Bug - wer findet den Fehler?

[carapau]

Guten Tag zusammen,

ich benutze Nested Sets für eine Seitenstruktur. Jedoch gibt es noch Bugs, die ich beseitigen möchte. Entweder durch das Verbieten bestimmter Anwender-Aktionen oder eine Korrektur in der Logik.

Code

                $src_tree  = $P->get_page($_GET['src_page_id']);  // Die Seite soll verschoben werden
        $dest_tree = $P->get_page($_GET['dest_page_id']); // Die Zielseite
        $move = $_GET['move']; // Wie soll die Seite verschoben werden? (INTO, ABOVE, BELOW)
        
        // Werte der Zielseite
        $dest_lft         = $dest_tree["lft"];         // Links 
        $dest_rgt         = $dest_tree["rgt"];         // Rechts
        $dest_children     = $dest_tree["children"];     // Anzahl der Kinder
                
        // Werte der zu verschiebenen Seite
        $src_lft         = $src_tree["lft"];         // Links
        $src_rgt         = $src_tree["rgt"];         // Rechts
        $src_children     = $src_tree["children"];     // Anzahl der Kinder
        
        // Einträge aus der Struktur entfernen / Platz machen
        $sql[] = "UPDATE pages SET lft = lft*(-1) WHERE lft BETWEEN $src_lft AND $src_rgt";
        $sql[] = "UPDATE pages SET rgt = rgt*(-1) WHERE rgt BETWEEN $src_lft AND $src_rgt";
    
        // Lücken schließen
        $sql[] = "UPDATE pages SET lft = lft-($src_rgt-$src_lft+1) WHERE lft>$src_rgt";
        $sql[] = "UPDATE pages SET rgt = rgt-($src_rgt-$src_lft+1) WHERE rgt>=$src_rgt";
        
        $exec_sql = false; // SQL nicht ausführen    

        // Wie soll verschoben werden?
        switch ($move) {
            // INTO
            case 'into':
                // Einträge ändern
                $sql[] = "UPDATE pages SET lft=lft+($src_rgt-$src_lft+1) WHERE lft>$dest_rgt";
                $sql[] = "UPDATE pages SET rgt=rgt+($src_rgt-$src_lft+1) WHERE rgt>=$dest_rgt";
                
                // Einträge an gewünschte Stelle schieben
                $sql[] = "UPDATE pages SET lft=$dest_rgt+((lft*(-1))-$src_lft) WHERE lft<0";
                $sql[] = "UPDATE pages SET rgt=$dest_rgt+((rgt*(-1))-$src_lft) WHERE rgt<0";
                
                $exec_sql = true; // SQL ausführen
                break;
                
            // ABOVE
            case 'above':
                // Einträge ändern
                $sql[] = "UPDATE pages SET rgt=rgt+($src_rgt-$src_lft+1) WHERE rgt>$dest_lft";
                $sql[] = "UPDATE pages SET lft=lft+($src_rgt-$src_lft+1) WHERE lft>=$dest_lft";
                
                // Einträge an gewünschte Stelle schieben
                $sql[] = "UPDATE pages SET lft=$dest_lft+((lft*(-1))-$src_lft) WHERE lft<0";
                $sql[] = "UPDATE pages SET rgt=$dest_lft+((rgt*(-1))-$src_lft) WHERE rgt<0";
                
                $exec_sql = true; // SQL ausführen
                break;
                
            // BELOW
            case 'below':
                // Einträge ändern
                $sql[] = "UPDATE pages SET rgt=rgt+($src_rgt-$src_lft+1) WHERE rgt>$dest_rgt";
                $sql[] = "UPDATE pages SET lft=lft+($src_rgt-$src_lft+1) WHERE lft>$dest_rgt";
                
                // Einträge an gewünschte Stelle schieben
                $sql[] = "UPDATE pages SET lft=$dest_rgt+((lft*(-1))-$src_lft+1) WHERE lft<0";
                $sql[] = "UPDATE pages SET rgt=$dest_rgt+((rgt*(-1))-$src_lft+1) WHERE rgt<0";
                
                $exec_sql = true; // SQL ausführen
                break;
        }
        
        // SQL ausführen?
        if ($exec_sql) {
            // Statements durchlaufen
            for ($i = 0; $i < count($sql); $i++) {
                // Query ausführen
                if (DB::getInstance()->query($sql[$i])) {
                    echo "Query erfolgreich ausgeführt!<br/>";
                } else {
                    echo "Fehler: ".$sql[$i]."<hr/>";
                }
            }
        } 

Fehler lässt sich reproduzieren.
1. Menschen INTO Katzen [COLOR="YellowGreen"](geht[/COLOR])
2. Menschen INTO Root ([COLOR="Red"]Fehler[/COLOR])
3. Menschen INTO Root wiederholen ([COLOR="YellowGreen"]geht[/COLOR])

Die Schritte mit Veränderungen der Werte als Grafik (Klick):


Uploaded with ImageShack.us

Ich versteh nicht was das soll. Grundsätzlich geht es ja, leider nur beim Wiederholen der Aktion.

Folgendes funktioniert:
# ABOVE
- Verschieben von Teilbäumen (Menschen ABOVE Tiere)
- Verschieben von Knoten (Frau ABOVE Mann)
# INTO
- Teilweise Verschieben von Teilbaum (Menschen INTO Katzen)
# BELOW
- Teilweise Verschieben von Teilbäumen (Menschen BELOW Katzen)

Quellen:
- Nested Sets ? Wikipedia
- Nested Sets – Verschachtelte Bäume mit MySQL - Arne Klempert
- aseantic Blog - Nested Sets - Teil 4: Komplexe SQL-Abfragen für Nested Sets
- Bäume verschieben in Nested Sets | REDUXO

Freue mich auf Antworten!
carapau

[TobiaZ]

2. Menschen INTO Root (Fehler)
3. Menschen INTO Root wiederholen (geht)

Welche Queries werden ausgeführt? Isoliere sie.

Ist das Problem immer noch reproduzierbar? Schaue nach, welche Queries beim ersten mal (wie viele) affected_rows haben und vergleiche dies mit den betroffenen Zeilen beim zweiten durchlauf.

Was fällt auf?

[AmicaNoctis]

Hallo,

evtl. hilft ein Blick in mein Blog

Gruß,

Amica

[carapau]

Hallo,

evtl. hilft ein Blick in mein Blog

Gruß,

Amica

Deinen Code hab ich vorher benutzt bis immer häufiger nicht reproduzierbare Fehler auftauchten und mir meine ganze Struktur zerschossen haben. Kann dir leider nicht sagen woran es genau lag und ob es eventuell mein Fehler war, aber das ist der Grund warum ich jetzt alles von vorne aufrolle. Trotzdem Danke!

Ich werde mir gleich mal die Queries angucken, vergleichen und posten.

[carapau]

Welche Queries werden ausgeführt? Isoliere sie.

Ist das Problem immer noch reproduzierbar? Schaue nach, welche Queries beim ersten mal (wie viele) affected_rows haben und vergleiche dies mit den betroffenen Zeilen beim zweiten durchlauf.

Was fällt auf?

Hier die ausgeführten Statements und in Klammern dahinter die affected rows. Ein Unterschied ist deutlich zu sehen, aber wie kann man das vermeiden? Ich blick da gerade irgendwie überhaupt nicht durch.

1. Menschen INTO Katzen (geht)

UPDATE pages SET lft=lft*(-1) WHERE lft BETWEEN 8 AND 13 (affected: 3)
UPDATE pages SET rgt=rgt*(-1) WHERE rgt BETWEEN 8 AND 13 (affected: 3)
UPDATE pages SET lft=lft-(13-8+1) WHERE lft>13 (affected: 0)
UPDATE pages SET rgt=rgt-(13-8+1) WHERE rgt>=13 (affected: 1)
UPDATE pages SET lft=lft+(13-8+1) WHERE lft>6 (affected: 0)
UPDATE pages SET rgt=rgt+(13-8+1) WHERE rgt>=6 (affected: 3)
UPDATE pages SET lft=6+((lft*(-1))-8) WHERE lft<0 (affected: 3)
UPDATE pages SET rgt=6+((rgt*(-1))-8) WHERE rgt<0 (affected: 3)

2. Menschen INTO Root ([COLOR="Red"]Error![/COLOR])

UPDATE pages SET lft=lft*(-1) WHERE lft BETWEEN 6 AND 11 (affected: 3)
UPDATE pages SET rgt=rgt*(-1) WHERE rgt BETWEEN 6 AND 11 (affected: 3)
UPDATE pages SET lft=lft-(11-6+1) WHERE lft>11 (affected: 0)
UPDATE pages SET rgt=rgt-(11-6+1) WHERE rgt>=11 (affected: 3)
UPDATE pages SET lft=lft+(11-6+1) WHERE lft>14 (affected: 0)
UPDATE pages SET rgt=rgt+(11-6+1) WHERE rgt>=14 (affected: 0)
UPDATE pages SET lft=14+((lft*(-1))-6) WHERE lft<0 (affected: 3)
UPDATE pages SET rgt=14+((rgt*(-1))-6) WHERE rgt<0 (affected: 3)

3. Menschen INTO Root wiederholen (geht)

UPDATE pages SET lft=lft*(-1) WHERE lft BETWEEN 14 AND 19 (affected: 3)
UPDATE pages SET rgt=rgt*(-1) WHERE rgt BETWEEN 14 AND 19 (affected: 3)
UPDATE pages SET lft=lft-(19-14+1) WHERE lft>19 (affected: 0)
UPDATE pages SET rgt=rgt-(19-14+1) WHERE rgt>=19 (affected: 0)
UPDATE pages SET lft=lft+(19-14+1) WHERE lft>8 (affected: 0)
UPDATE pages SET rgt=rgt+(19-14+1) WHERE rgt>=8 (affected: 1)
UPDATE pages SET lft=8+((lft*(-1))-14) WHERE lft<0 (affected: 3)
UPDATE pages SET rgt=8+((rgt*(-1))-14) WHERE rgt<0 (affected: 3)

[AmicaNoctis]

Deinen Code hab ich vorher benutzt bis immer häufiger nicht reproduzierbare Fehler auftauchten und mir meine ganze Struktur zerschossen haben.

Das ist schade. Inzwischen ist er bereits durchaus praxiserprobt und hat sich als robust erwiesen, solange der Baum nicht schon vorher kaputt war (Lücken, Überschneidungen, Duplikate, …) und die Parameter korrekt übergeben werden.

[carapau]

Das ist schade. Inzwischen ist er bereits durchaus praxiserprobt und hat sich als robust erwiesen, solange der Baum nicht schon vorher kaputt war (Lücken, Überschneidungen, Duplikate, …) und die Parameter korrekt übergeben werden.

An deinem Code scheint es "leider" doch nicht zu liegen. Schon wieder ist ein Baum zerschossen und ich weiss überhaupt nicht woran es liegt. Reproduzieren kann ich leider auch nicht, da das Problem bisher immer plötzlich auftrat, wenn man nicht damit rechnet.

Ich habe meinen Code aus diversen Tutorials zusammen gebastelt und wahrscheinlich irgendwo einen kleinen aber entscheidenen Fehler.

Hat jemand von Euch eventuell eine vollständige Klasse übrig?

[AmicaNoctis]

Ich hab auf Basis meiner Single-Statement-Lösung auch PHP-Klassen geschrieben. Die sind aber nur für PHP ab Version 5.3 ausgelegt und auch nicht kostenlos.

Hier mal ein Feature-Überblick in Interface-Schreibweise:

<?php
    namespace nestedSet;
    use \RuntimeException;

    /**
     * Represents a node in a Tree, possibly containing other TreeNode instances as children.
     * The database table the nodes are based on may contain additional columns, which are
     * accessible as properties through magic getter and setter methods.
     * Instances of this class cannot be created directly and must be created through the Tree's
     * createNode() method.
     * @author  Amica Noctis <info@amicanoctis.de>
     * @version 1.1
     * @since   PHP 5.3
     */
    class TreeNode {

        /**
         * Returns the value of the current node for the specified column in the underlying table.
         * @return pName A name of the column as string.
         */
        public function __get ($pName);

        /**
         * Sets the value of the current node for the specified column in the underlying table.
         * @param pName  A name of the column as string.
         * @param pValue The new value.
         */
        public function __set ($pName, $pValue);

        /**
         * Returns a string representation of the current node including all descendants.
         */
        public function __toString ();

        /**
         * Deletes the current node and all descendants from the tree.
         */
        public function delete ();

        /**
         * Returns all column names of the current note from the underlying table.
         * @return array An array of column names.
         */
        public function getAttributeNames ();

        /**
         * Returns all nodes which are direct children of the current node.
         * @return array An array of TreeNode instances
         */
        public function getChildren ();

        /**
         * Returns the TreeNode being the first direct child.
         * @return TreeNode The first child or null if the current node has no children
         */
        public function getFirstChild ();

        /**
         * Returns the ID (primary key) of the current node.
         * @return integer The ID of the current node
         */
        public function getId ();

        /**
         * Returns the TreeNode being the last direct child.
         * @return TreeNode The last child or null if the current node has no children
         */
        public function getLastChild ();

        /**
         * Returns the TreeNode being the next sibling of the current node.
         * @return TreeNode The next sibling or null if the current node is the last child
         *                  of its parent
         */
        public function getNextSibling ();

        /**
         * Returns the TreeNode being the direct parent of the current node. If the current node
         * is a root node, this method returns the Tree itself.
         * @return TreeNode The parent of the current node
         */
        public function getParent ();

        /**
         * Returns the TreeNode being the previous sibling of the current node.
         * @return TreeNode The previous sibling or null if the current node is the first child
         *                  of its parent
         */
        public function getPreviousSibling ();

        /**
         * Returns the Tree containing the current node.
         * @return Tree The tree containing the current node
         */
        public function getTree ();

        /**
         * Moves the current node to the position in the tree immediately before the
         * specified reference node.
         * @param pNode The TreeNode before which the current node will be moved
         */
        public function moveBefore (TreeNode $pNode);

        /**
         * Moves the current node inside the specified reference node, so that it will be the last
         * child of the reference node.
         * @param pNode The TreeNode which will be the new parent of the current node.
         */
        public function moveInto (TreeNode $pNode);

        /**
         * Swaps the current node with the specified reference node, so that each one will be
         * located in the other's former position.
         * @param pNode The TreeNode to swap the current node with.
         */
        public function swap (TreeNode $pNode);
    }
?>

<?php
    namespace nestedSet;
    use \InvalidArgumentException;
    use \PDO;
    use \RuntimeException;

    /**
     * Represents a tree based on the nested set model and supporting multiple root nodes.
     * All operations are carried out directly on the database, so any delete operations are final.
     * @author  Amica Noctis <info@amicanoctis.de>
     * @version 1.1
     * @since   PHP 5.3
     */
    class Tree extends TreeNode {

        /**
         * Creates a new instance using the given connection object and the specified table
         * and columns.
         * @param pPDO        A PDO instance (currently only mysqlnd supported)
         * @param pSchemaName The name of the schema containing the table holding the tree
         * @param pTableName  The name of the table holding the tree
         * @param pIdName     The name of the primary key column
         * @param pLftName    The name of the left value column
         * @param pRgtName    The name of the right value column
         */
        public function __construct (
            PDO $pPDO,
            $pSchemaName,
            $pTableName = "tree",
            $pIdName = "id",
            $pLftName = "lft",
            $pRgtName = "rgt"
        );

        /**
         * Creates a new TreeNode at the end of the tree, i. e. being the last root node.
         * It can be moved to the desired location using the moveBefore or the moveInto method.
         * @return TreeNode The new node
         */
        public function createNode ();

        /**
         * Deletes the whole tree.
         */
        public function delete ();

        /**
         * Returns all root nodes.
         * @return array An array of TreeNode instances
         */
        public function getChildren ();

        /**
         * Returns the TreeNode being the first root node.
         * @return TreeNode The first root node or null if there are no root nodes
         */
        public function getFirstChild ();

        /**
         * Returns the TreeNode being the last root node.
         * @return TreeNode The last root node or null if there are no root nodes
         */
        public function getLastChild ();

        /**
         * Returns always null, since the Tree itself cannot have siblings.
         * @return null
         */
        public function getNextSibling ();

        /**
         * Returns the TreeNode having the specified ID (primary key). It will be searched within
         * the whole tree, not only among the root nodes.
         * @param pId       The numeric primary key to search for (must be an integer)
         * @return TreeNode The TreeNode if found, otherwise null
         */
        public function getNodeById ($pId);

        /**
         * Returns always null, since the Tree itself is the parent to all other nodes it contains.
         * @return null
         */
        public function getParent ();

        /**
         * Returns always null, since the Tree itself cannot have siblings.
         * @return null
         */
        public function getPreviousSibling ();

        /**
         * The tree itself cannot be moved.
         * @param pNode The TreeNode before which the Tree is attempted to move
         * @throws InvalidArgumentException
         */
        public function moveBefore (TreeNode $pNode);

        /**
         * The tree itself cannot be moved.
         * @param pNode The TreeNode inside which the Tree is attempted to move
         * @throws InvalidArgumentException
         */
        public function moveInto (TreeNode $pNode);

        /**
         * The tree itself cannot be swapped.
         * @param pNode The TreeNode which the Tree is attempted to be swapped with
         * @throws InvalidArgumentException
         */
        public function swap (TreeNode $pNode);
    }
?>

[carapau]

Ich hab auf Basis meiner Single-Statement-Lösung auch PHP-Klassen geschrieben. Die sind aber nur für PHP ab Version 5.3 ausgelegt und auch nicht kostenlos.

Hier mal ein Feature-Überblick in Interface-Schreibweise:

<?php
    namespace nestedSet;
    use \RuntimeException;

    /**
     * Represents a node in a Tree, possibly containing other TreeNode instances as children.
     * The database table the nodes are based on may contain additional columns, which are
     * accessible as properties through magic getter and setter methods.
     * Instances of this class cannot be created directly and must be created through the Tree's
     * createNode() method.
     * @author  Amica Noctis <info@amicanoctis.de>
     * @version 1.1
     * @since   PHP 5.3
     */
    class TreeNode {

        /**
         * Returns the value of the current node for the specified column in the underlying table.
         * @return pName A name of the column as string.
         */
        public function __get ($pName);

        /**
         * Sets the value of the current node for the specified column in the underlying table.
         * @param pName  A name of the column as string.
         * @param pValue The new value.
         */
        public function __set ($pName, $pValue);

        /**
         * Returns a string representation of the current node including all descendants.
         */
        public function __toString ();

        /**
         * Deletes the current node and all descendants from the tree.
         */
        public function delete ();

        /**
         * Returns all column names of the current note from the underlying table.
         * @return array An array of column names.
         */
        public function getAttributeNames ();

        /**
         * Returns all nodes which are direct children of the current node.
         * @return array An array of TreeNode instances
         */
        public function getChildren ();

        /**
         * Returns the TreeNode being the first direct child.
         * @return TreeNode The first child or null if the current node has no children
         */
        public function getFirstChild ();

        /**
         * Returns the ID (primary key) of the current node.
         * @return integer The ID of the current node
         */
        public function getId ();

        /**
         * Returns the TreeNode being the last direct child.
         * @return TreeNode The last child or null if the current node has no children
         */
        public function getLastChild ();

        /**
         * Returns the TreeNode being the next sibling of the current node.
         * @return TreeNode The next sibling or null if the current node is the last child
         *                  of its parent
         */
        public function getNextSibling ();

        /**
         * Returns the TreeNode being the direct parent of the current node. If the current node
         * is a root node, this method returns the Tree itself.
         * @return TreeNode The parent of the current node
         */
        public function getParent ();

        /**
         * Returns the TreeNode being the previous sibling of the current node.
         * @return TreeNode The previous sibling or null if the current node is the first child
         *                  of its parent
         */
        public function getPreviousSibling ();

        /**
         * Returns the Tree containing the current node.
         * @return Tree The tree containing the current node
         */
        public function getTree ();

        /**
         * Moves the current node to the position in the tree immediately before the
         * specified reference node.
         * @param pNode The TreeNode before which the current node will be moved
         */
        public function moveBefore (TreeNode $pNode);

        /**
         * Moves the current node inside the specified reference node, so that it will be the last
         * child of the reference node.
         * @param pNode The TreeNode which will be the new parent of the current node.
         */
        public function moveInto (TreeNode $pNode);

        /**
         * Swaps the current node with the specified reference node, so that each one will be
         * located in the other's former position.
         * @param pNode The TreeNode to swap the current node with.
         */
        public function swap (TreeNode $pNode);
    }
?>

<?php
    namespace nestedSet;
    use \InvalidArgumentException;
    use \PDO;
    use \RuntimeException;

    /**
     * Represents a tree based on the nested set model and supporting multiple root nodes.
     * All operations are carried out directly on the database, so any delete operations are final.
     * @author  Amica Noctis <info@amicanoctis.de>
     * @version 1.1
     * @since   PHP 5.3
     */
    class Tree extends TreeNode {

        /**
         * Creates a new instance using the given connection object and the specified table
         * and columns.
         * @param pPDO        A PDO instance (currently only mysqlnd supported)
         * @param pSchemaName The name of the schema containing the table holding the tree
         * @param pTableName  The name of the table holding the tree
         * @param pIdName     The name of the primary key column
         * @param pLftName    The name of the left value column
         * @param pRgtName    The name of the right value column
         */
        public function __construct (
            PDO $pPDO,
            $pSchemaName,
            $pTableName = "tree",
            $pIdName = "id",
            $pLftName = "lft",
            $pRgtName = "rgt"
        );

        /**
         * Creates a new TreeNode at the end of the tree, i. e. being the last root node.
         * It can be moved to the desired location using the moveBefore or the moveInto method.
         * @return TreeNode The new node
         */
        public function createNode ();

        /**
         * Deletes the whole tree.
         */
        public function delete ();

        /**
         * Returns all root nodes.
         * @return array An array of TreeNode instances
         */
        public function getChildren ();

        /**
         * Returns the TreeNode being the first root node.
         * @return TreeNode The first root node or null if there are no root nodes
         */
        public function getFirstChild ();

        /**
         * Returns the TreeNode being the last root node.
         * @return TreeNode The last root node or null if there are no root nodes
         */
        public function getLastChild ();

        /**
         * Returns always null, since the Tree itself cannot have siblings.
         * @return null
         */
        public function getNextSibling ();

        /**
         * Returns the TreeNode having the specified ID (primary key). It will be searched within
         * the whole tree, not only among the root nodes.
         * @param pId       The numeric primary key to search for (must be an integer)
         * @return TreeNode The TreeNode if found, otherwise null
         */
        public function getNodeById ($pId);

        /**
         * Returns always null, since the Tree itself is the parent to all other nodes it contains.
         * @return null
         */
        public function getParent ();

        /**
         * Returns always null, since the Tree itself cannot have siblings.
         * @return null
         */
        public function getPreviousSibling ();

        /**
         * The tree itself cannot be moved.
         * @param pNode The TreeNode before which the Tree is attempted to move
         * @throws InvalidArgumentException
         */
        public function moveBefore (TreeNode $pNode);

        /**
         * The tree itself cannot be moved.
         * @param pNode The TreeNode inside which the Tree is attempted to move
         * @throws InvalidArgumentException
         */
        public function moveInto (TreeNode $pNode);

        /**
         * The tree itself cannot be swapped.
         * @param pNode The TreeNode which the Tree is attempted to be swapped with
         * @throws InvalidArgumentException
         */
        public function swap (TreeNode $pNode);
    }
?>

So ähnlich ist meine auch aufgebaut, leider zählt das was da rein gehört Was willst du denn dafür haben?